Add the last reviewed version to Cargo.toml / [dependencies]:

crossterm_style = "0.5.1"

Filter reviews clicking on the numbers in the summary.

Full column names in tooltip hints: rating Negative, rating Neutral, rating Positive, rating Strong, thoroughness, understanding, reviews count.

Neg
Neu
Pos
Str
tho
und
rev
1
1
1
1
crate version
rating
date
reviewer
thoroughness, understanding
crossterm_style 0.5.1
negative
2019-09-28
medium, medium
issues:
high
Unguarded access of static mut ORIGINAL_CONSOLE_COLOR is unsound

Pros:

  • Styling!

Cons:

  • Poor win7 support
  • Unsound
FileRatingNotes
.github/CODEOWNERS+1
docs/CONTRIBUTING.md+1
src/enums/attribute.rs+1Verified codes vs https://en.wikipedia.org/wiki/ANSI_escape_code#SGR_parameters
src/enums/color.rs0FromStr for Color doesn't implement RGB parsing despite supporting RGB
src/enums/colored.rs+1
src/ansi_color.rs0Verified codes vs https://en.wikipedia.org/wiki/ANSI_escape_code#8-bit . Could've simplified match logic a bit.
src/color.rs-1Bugs (#261, #263)
src/enums.rs+1
src/lib.rs+1
src/macros.rs+1
src/objectstyle.rs+1
src/styledobject.rs0Odd fg/bg naming style. Also reset seems suboptimal if nesting styles?
src/traits.rs+1Not sure how wild I am about &str extension methods, but it works.
src/winapi_color.rs-1Unsound static mut ORIGINAL_CONSOLE_COLOR if original_console_color ever called before init_console_color, which appears possible #245
.cargo_vcs_info.json+1
.cargo-ok+1
.gitignore+1
.travis.yml+1No MSRV
Cargo.toml+1MIT, winapi, crossterm_winapi, serde
Cargo.toml.orig+1MIT, winapi, crossterm_winapi, serde
CHANGELOG.md+1
LICENSE+1MIT
README.md+1
OtherRatingNotes
unsafe-1#245 unsound static mut
fs+1None
io0Not sure what to blame for win7 styling failures
docs+1
tests-1Few, hard anyways

src/winapi_color.rs

LineWhatNotes
46fn WinApiColor::set_fgmask should be 0x00F0 instead of special casing BACKGROUND_INTENSITY
78fn WinApiColor::set_bgmask should be 0x000F instead of special casing FOREGROUND_INTENSITY
118fn color_valueIsn't Color::White and Color::Grey here swapped in terms of colors to be used?
119fn color_valueIsn't Color::White and Color::Grey here swapped in terms of colors to be used?
133fn color_value0 seems like a poor choice for fallback fg color, especially when it's also used for bg color
153fn color_valueIsn't Color::White and Color::Grey here swapped in terms of colors to be used?
154fn color_valueIsn't Color::White and Color::Grey here swapped in terms of colors to be used?
133fn color_value0 seems like a mediocre choice for fallback bg color, especially when it's also used for fg color
172fn color_valueWait why the heck are we going to/from strings that makes 0 sense
191static mut ORIGINAL_CONSOLE_COLORUnsound access if reset called before set_??, which appears possible #245

© bestia.dev 2023, MIT License, Version: 2023.608.1636

Open source repository for this web app: https://github.com/bestia-dev/cargo_crev_web/