memchr is a basic crate for string search.
I trust the authors. I didn't review the source code.

Published to crates.io by: BurntSushi
High reputation and visibility in the rust community.
https://web.crev.dev/rust-reviews/people_of_rust/

memchr is a basic crate for string search.
I trust the authors. I didn't review the source code.

Published to crates.io by: BurntSushi
High reputation and visibility in the rust community.
https://web.crev.dev/rust-reviews/people_of_rust/

memchr is a basic crate for string search.
I trust the authors. I didn't review the source code.

Published to crates.io by: BurntSushi
High reputation and visibility in the rust community.
https://web.crev.dev/rust-reviews/people_of_rust/

memchr is a basic crate for string search.
I trust the authors. I didn't review the source code.

Published to crates.io by: BurntSushi
High reputation and visibility in the rust community.
https://web.crev.dev/rust-reviews/people_of_rust/

memchr is a basic crate for string search.
I trust the authors. I didn't review the source code.

Published to crates.io by: BurntSushi
High reputation and visibility in the rust community.
https://web.crev.dev/rust-reviews/people_of_rust/

I wrote this crate, so this review is a reflection as a result of writing
the code and then reviewing it again for this review.

The entire purpose of the memchr crate is to do this:

haystack.iter().position(|&b| b == needle)

... but really fast. As a result, this crate uses SIMD via CPU specific
vendor intrinsics. Consequently, there is a lot of unsafe code in this
crate. There is really no way to avoid this, other than perhaps using a
higher level platform independent SIMD API. But no such thing of sufficient
quality exists for stable Rust at the time of writing.

The testing strategy is the most important bit here. In particular, every
public API item is tested using a permutation of tests that exercise all
possible alignments found in a haystack. (Because the implementations used
aligned loads/stores, which are only correct if the address arithmetic is
correct.) Additionally, there are quickcheck tests that act as a sort of
fuzzer guaranteeing that the implementation is correct for a range of inputs.

I gave the highest rating possible because of the extensive use this crate
has seen, in addition to its level of testing. In particular, memchr
underlies a significant chunk of all text search in the Rust ecosystem.

memchr is a basic crate for string search.
I trust the authors. I didn't review the source code.

Published to crates.io by: BurntSushi
High reputation and visibility in the rust community.
https://web.crev.dev/rust-reviews/people_of_rust/

Not sure about the strict correctness of memrchr under stacked borrows but
the forward functions definitely seem fine. That said, miscompilation seems
unlikely since stacked borrows is more aggressive than llvm's noalias and raw
pointers do not receive that tag anyways.