logo

Rust crates reviews

Cryptographically verifiable, distributed dependency reviews

crate: scopeguard

https://lib.rs/crates/scopeguard/

Add the last reviewed version to Cargo.toml / [dependencies]:

scopeguard = "1.1.0"

Filter reviews clicking on the numbers in the summary.

Full column names in tooltip hints: rating Negative, rating Neutral, rating Positive, rating Strong, thoroughness, understanding, reviews count.

Neg
Neu
Pos
Str
tho
und
rev
2
3
1
1
1
1
1
crate version
rating
date
reviewer
thoroughness, understanding
scopeguard 1.1.0
positive
2020-04-29
medium, medium

Small, stable, and highly useful.

Most of the code is straightforward but to increase usability there are three
unsafe blocks. It seems feasible to write a completely safe version of the
API without hurting the main use case too much. The benefit, however, would
be slim except for those focussed on purging even well-reviewed local
unsafe. Let's explain how we agree with all reasoning, and documentation.

src/lib.rs:351:ScopeGuard::into_inner: Here it performs a manual move from
a to-be-forgotten value that can't be destructured due to the rules around
Drop types. It's slightly awkward to use mem::forgetafter the copy
instead of wrapping the value in a ManuallyDrop at the start but the
comment correctly explains why the order is equivalent and still sound. It
also seems odd that this pseudo-destructuring does not return the function
instance but only the value and thus always drops the functor which
potentially also drops any contained captured value and thus might panic.
That seems more ergonomic in the common case or when a pure function is used,
so it isn't critical.

src/lib.rs:422:impl Sync: This is likely the most involved here but the
comment explains it well enough. It might have been/be beneficial to create a
very small newtype wrapper that enforces that no such access by reference can
take place in future versions of the crate also. This would also reduce the
mental load, as this impl with all its type bounds would not be explicitly
required. It would nevertheless not reduce the amount of necessary soundness
reasoning so this is just polish.

src/lib.rs:455:Drop::drop for ScopeGuard: Same as into_inner but since
this is within the Drop impl there is no need (and possibility) to forget
self so this is self-explanatory. This could share a common core with the
into_inner method, a private inherent method that ptr::read's the stored
values. Avoiding duplication here would be more important if different ways
of destructuring existed.

scopeguard 1.0.0
positive
2019-08-21
medium, medium

Looks okay but I'd prefer to just avoid needing it.

scopeguard 1.0.0
positive
2019-10-04
low, low

No malicious code. The unsafe parts seems sane, but they could use a
a review by someone more confident with unsafe.

scopeguard 0.3.3
positive
2020-01-02
low, medium

© bestia.dev 2021, MIT Licence, Version: 2021.1208.1729

Open source repository for this web app: https://github.com/bestia-dev/cargo_crev_web/