Cryptographically verifiable, distributed dependency reviews
Add the last reviewed version to Cargo.toml / [dependencies]:
rc-borrow = "1.0.0"Please, use mobile in landscape.
Filter reviews clicking on the numbers in the summary.
Full column names in tooltip hints: rating Negative, rating Neutral, rating Positive, rating Strong, thoroughness, understanding, reviews count.
I am the author of this crate. As such, I obviously trust it and believe it is useful.
So this review will instead point at the trickiest parts and try to rationalize them.
Do not believe cargo-geiger for this crate. The implementation is primarily macro-generated,
and cargo-geiger does not see into unsafe generated in macros.
That said, this crate is fairly simple and self-evident.
The main tricky bit is around pointer provenance when reconstructing the (A)Rc.
See https://internals.rust-lang.org/t/_/11463/11 for some context.
The standard library currently does this wrong, even!
Getting the "raw" reference as
&**arcgives shared immutable provenance,and (A)Rc requires "raw mutable" provenance, because of get_mut.
If you're reading this and you ever upgrade &T to (A)Rc, replace it with this crate!
The crate uses autocfg to automatically probe for the "fix" methods of std providing a
(A)Rc::as_raw, so will automatically upgrade to the purely sound version when it's available.
Smoke tests are run under miri, but the crate could potentially do with some more examples
as well as some more tests to ensure that all of the functionality works as advertised.
I've only put this review as positive rather than strong because of a lack of real-world use.
As of yet, the library is just of theoretical use, and has yet to be stress tested for real.