logo

Rust crates reviews

Cryptographically verifiable, distributed dependency reviews

reviewer: leo60228

https://lib.rs/leo60228

$ cargo crev repo fetch url https://github.com/leo60228/crev-proofs
$ cargo crev id trust 2LuQSTppPubecRKRky5i_owgDcpbZhuFE3iXyLky5w4

repo: https://github.com/leo60228/crev-proofs

crate version
rating
date
reviewer
thoroughness, understanding
negative
2020-01-06
leo60228
low, medium
alternative:
std

Crate returns &'static str returned from transmuting a &str, which may become unsound at any time. It also has much more code than simply storing an std::io::Error in an Arc.

positive
2021-11-18
leo60228
low, medium

Simple futures-based wrapper on top of other crates, primarily polling.

positive
2021-09-28
leo60228
low, medium

simple macro

neutral
2021-11-18
leo60228
medium, high

Code is trivial, but I feel like assuming 64-byte cache lines on non-ARM64/x64 might be overly optimistic.

positive
2021-09-28
leo60228
low, medium

only minor changes

positive
2021-11-18
leo60228
low, low

Crate is simple enough, but I don't fully understand the low-level concurrency details.

positive
2020-01-06
leo60228
low, high

proc-macro-hack wrapper crate

positive
2020-01-06
leo60228
low, medium

Very simple and minimal crate

negative
2020-03-21
leo60228
none, low

Contains large amounts of UB and segfault-prone code. See https://github.com/servo/core-foundation-rs/issues/361 and https://github.com/servo/core-foundation-rs/issues/291.

positive
2021-09-28
leo60228
low, medium

adds some new features, no changes to existing code

positive
2021-09-28
leo60228
low, medium

changes imports for no_std, no changes to code

positive
2021-11-18
leo60228
low, medium

Most of what this crate does is simple, and it's very thoroughly commented.

positive
2021-11-18
leo60228
low, medium

Crate just consists of a few traits, which are all defined as you'd expect.

positive
2021-09-28
leo60228
low, medium

just refactoring

positive
2021-09-28
leo60228
low, medium

only minor changes

positive
2020-01-06
leo60228
low, medium
alternative:
core

This crate is copy/pasted from core::mem::MaybeUninit for older rustc.

neutral
2020-01-06
leo60228
low, medium
issues:
low

Simple crate. Triggers UB but there is no workaround on current Rust.

positive
2021-11-13
leo60228
low, high

Mostly consists of types with a few simple helpers. Last commit is a year ago, but there aren't any outstanding issues or PRs and the author still seems to be active.

positive
2021-11-18
leo60228
low, medium

I reviewed this crate with default features. All code outside the sync module is simple and clearly correct, and the code in the sync module comes from std with minor changes.

positive
2021-11-18
leo60228
low, low

Code is short and seems reasonable, but I'm not great at low-level concurrent code.

positive
2020-01-06
leo60228
medium, medium

Simpler version of pin-project

strong
2020-01-06
leo60228
low, medium
alternative:
std

Very small crate, has useful macros

positive
2021-11-18
leo60228
low, medium

I primarily reviewed the code for Linux, and quickly skimmed other OSes to make sure they weren't doing anything obviously malicious. The Linux code seems to map cleanly to epoll, though there may be subtleties in the underlying API I'm unaware of.

positive
2021-09-28
leo60228
none, medium

changes seem clear

© bestia.dev 2021, MIT Licence, Version: 2021.1208.1729

Open source repository for this web app: https://github.com/bestia-dev/cargo_crev_web/