logo

Rust crates reviews

Cryptographically verifiable, distributed dependency reviews

reviewer: programmerjake

https://lib.rs/programmerjake

$ cargo crev repo fetch url https://github.com/programmerjake/crev-proofs
$ cargo crev id trust dUc4luSnPuYlfYarXUizPOSBLUBZguTVOQUCHmAKSps

repo: https://github.com/programmerjake/crev-proofs

crate version
rating
date
reviewer
thoroughness, understanding
positive
2020-03-22
programmerjake
medium, high

original author

positive
2019-10-27
programmerjake
medium, high

original author

positive
2019-10-22
programmerjake
medium, high

original author

positive
2019-09-18
programmerjake
medium, high

original author

positive
2019-08-26
programmerjake
medium, high

original author; placeholder package

positive
2019-08-26
programmerjake
medium, high

dependency of softfloat-sys

positive
2020-11-05
programmerjake
low, medium

quick read through

negative
2021-04-14
programmerjake
low, medium
issues:
low
issues:
high
issues:
low
issues:
low
issues:
medium

Found some unsound code, reported in #241

Going through the code, there are many places where non-public functions are not marked unsafe
even when they exhibit UB if given garbage input. Since those functions are not publically visible,
external users can't directly cause UB from safe code, but I'd consider that a code style issue. Reported in #244

There are several places where lifetimes seem to have been ignored, unnecessarily restricting users. Reported in #243

ExecutionEngine is not thread-safe, even though the underlying LLVM type is. Reported in #242

The documentation for TargetMachine::write_to_file is misleading and incorrect. Reported in #240

positive
2020-11-05
programmerjake
low, high

original author

positive
2020-11-05
programmerjake
low, high

original author

positive
2020-11-05
programmerjake
medium, high

read through v0.3.0 code after contributing to master version

positive
2019-12-15
programmerjake
medium, high

original author

positive
2019-08-26
programmerjake
none, medium

original author; rating not strong because it only builds on Linux; none for throrughness because I didn't review all of softfloat's C code.

positive
2020-11-05
programmerjake
low, medium

read through source, previously contributed code to add support for "string" VarType

© bestia.dev 2023, MIT License, Version: 2023.608.1636

Open source repository for this web app: https://github.com/bestia-dev/cargo_crev_web/